Format Query Data adding Last Modified Date #566
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
| @@ -51,16 +51,18 @@ def format_data( | |||
|
|
|||
There was a problem hiding this comment.
Apart from the changes already in the PR, should the changes also include modifying that new workflow that's being worked on, check_and_update_missing_query_forms.yaml? To also include the additional segments for lastModified in the generated queries?
There was a problem hiding this comment.
We also need the gender concatenations for #564 to be included in the query generations 🤔
There was a problem hiding this comment.
But then I worry a bit about putting group by into all of the queries like this. Maybe the thing to do is handle this in the formatting script where basically values are concatenated if they're already present in the resulting data. Spanish nouns gender just isn't really a useful field with the way the data has been structured.
And also, I just remembered that @axif0 mentioned that this has been added to the other PR in e363282 😊
There was a problem hiding this comment.
So we're good to go here :) :)
There was a problem hiding this comment.
And also, I just remembered that @axif0 mentioned that this has been added to the other PR
Ah nice!
I hadn't seen that before - good stuff! 👍 way to go
There was a problem hiding this comment.
Thanks so much for this, @axif0! Really appreciate that we're making so much progress on this already and building for sustainable API calls in the future 🚀😊
|
Re discussion in #566 (comment), e363282 added the requested changes to #563, so we are good to merge here and #562 will be closed when the other PR is brought in 🚀 |
Contributor checklist
pytestcommand as directed in the testing section of the contributing guideDescription
Added
modified_dateindata_formattedin Query Data.Related issue